[SPARK-52842][SQL] New functionality and bugfixes for single-pass analyzer #51513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihailotim-db
force-pushed
the
mihailotim-db/codesync_single_pass
branch
5 times, most recently
from
6746598 to
958c2d6
Compare
mihailotim-db
changed the title
mihailotim-db
force-pushed
the
mihailotim-db/codesync_single_pass
branch
from
958c2d6 to
b08cfab
Compare
mihailotim-db
force-pushed
the
mihailotim-db/codesync_single_pass
branch
from
b08cfab to
5293ea6
Compare
cloud-fan
approved these changes
Jul 18, 2025
|
the docker test failure is unrelated, thanks, merging to master! |
haoyangeng-db
pushed a commit
to haoyangeng-db/apache-spark
that referenced
this pull request
Jul 22, 2025
…lyzer ### What changes were proposed in this pull request? This PR adds new functionality to single-pass analyzer and addresses current issues: - Adds support for `TABLESAMPLE`, `SemiStructuredExtract`, `GetJsonObject` and `JsonTuple` - Adds support for LCA in Aggregate - Run `PullOutNondeterministic` as a post-resolution rule - Move `ExplicitlyUnsupportedResolverFeature` checks to `ResolverGuard` where possible - Fix `NameScope` name resolution to match fixed-point's fallback behavior when failing to resolve in one scope - Fix type coercion caused by missing `TypeCoercionRules` - Fix `ExprId` assignment - Various compatibility and failure fixes ### Why are the changes needed? To replace the existing Spark Analyzer with the single-pass. one. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI with ANALYZER_DUAL_RUN_LEGACY_AND_SINGLE_PASS_RESOLVER. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#51513 from mihailotim-db/mihailotim-db/codesync_single_pass. Authored-by: Mihailo Timotic <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds new functionality to single-pass analyzer and addresses current issues:
TABLESAMPLE,SemiStructuredExtract,GetJsonObjectandJsonTuplePullOutNondeterministicas a post-resolution ruleExplicitlyUnsupportedResolverFeaturechecks toResolverGuardwhere possibleNameScopename resolution to match fixed-point's fallback behavior when failing to resolve in one scopeTypeCoercionRulesExprIdassignmentWhy are the changes needed?
To replace the existing Spark Analyzer with the single-pass. one.
Does this PR introduce any user-facing change?
No
How was this patch tested?
CI with ANALYZER_DUAL_RUN_LEGACY_AND_SINGLE_PASS_RESOLVER.
Was this patch authored or co-authored using generative AI tooling?
No